Review Request 119115: DolphinTabWidget

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119115/#review64031
-----------------------------------------------------------

Ship it!


Looks good now, thanks! I have just one very minor suggestion (see below), but feel free to ignore it if you prefer. Thank you very much for your work on this!


dolphin/src/dolphintabwidget.h
<https://git.reviewboard.kde.org/r/119115/#comment44677>

    I think I would move this function behind the next one (also in the cpp file), such that the two "open activated tab" functions are grouped together.


- Frank Reininghaus


On Aug. 4, 2014, 6:53 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119115/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2014, 6:53 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 315904
>     http://bugs.kde.org/show_bug.cgi?id=315904
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow.
> 
> Removed the method for text squeezing because the QTabBar can do this automatically.
> 
> The tab sizes are different, any idea how to fix this?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphintabwidget.cpp PRE-CREATION 
>   dolphin/src/CMakeLists.txt 7b0210a 
>   dolphin/src/dolphinmainwindow.h 6f37f42 
>   dolphin/src/dolphinmainwindow.cpp d321d3b 
>   dolphin/src/dolphintabpage.h 95c02ed 
>   dolphin/src/dolphintabpage.cpp 82be6d5 
>   dolphin/src/dolphintabwidget.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119115/diff/
> 
> 
> Testing
> -------
> 
> Works great so far.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140808/4ba11c79/attachment.htm>