Review Request 119115: DolphinTabWidget

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119115/
-----------------------------------------------------------

(Updated Aug. 4, 2014, 8:53 p.m.)


Review request for Dolphin.


Changes
-------

Added a parameter to the activeViewChanged signal and remove the activeViewContainer method.


Repository: kde-baseapps


Description
-------

Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow.

Removed the method for text squeezing because the QTabBar can do this automatically.

The tab sizes are different, any idea how to fix this?


Diffs (updated)
-----

  dolphin/src/dolphintabwidget.cpp PRE-CREATION 
  dolphin/src/CMakeLists.txt 7b0210a 
  dolphin/src/dolphinmainwindow.h 6f37f42 
  dolphin/src/dolphinmainwindow.cpp d321d3b 
  dolphin/src/dolphintabpage.h 95c02ed 
  dolphin/src/dolphintabpage.cpp 82be6d5 
  dolphin/src/dolphintabwidget.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119115/diff/


Testing
-------

Works great so far.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140804/1f4d01dd/attachment.htm>