Review Request 119115: DolphinTabWidget

[Emmanuel Pescosta]

> On July 20, 2014, 11:45 p.m., Frank Reininghaus wrote:
> > dolphin/src/dolphinmainwindow.cpp, line 1231
> > <https://git.reviewboard.kde.org/r/119115/diff/3/?file=290350#file290350line1231>
> >
> >     The old code simply kept the connections to the signals of all views and URL navigators at all times.
> >     
> >     Could you comment on why you propose to introduce the disconnections and connections now?

Disconnecting of view signal-slot connections of inactive view fixes the root cause of bug 315904. You can simply reproduce it when you comment out the setActive/setFocus in DolphinSearchBox::eventFilter. This bug was only hidden by commit https://projects.kde.org/projects/kde/applications/kde-baseapps/repository/revisions/576481d114bdd0b7d1b4039612c7993f4cbb9b84/diff 

I think we should keep this to avoid other bugs in this area.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119115/#review62752
-----------------------------------------------------------


On July 15, 2014, 11:26 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119115/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 11:26 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow.
> 
> Removed the method for text squeezing because the QTabBar can do this automatically.
> 
> The tab sizes are different, any idea how to fix this?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 7b0210a 
>   dolphin/src/dolphinmainwindow.h 9c7f185 
>   dolphin/src/dolphinmainwindow.cpp 41bd626 
>   dolphin/src/dolphintabwidget.h PRE-CREATION 
>   dolphin/src/dolphintabwidget.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119115/diff/
> 
> 
> Testing
> -------
> 
> Works great so far.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140804/b60bbcb8/attachment.htm>