Review Request 117755: Mount partitions when you open them in a new tab.

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117755/#review56601
-----------------------------------------------------------

Ship it!


Looks good, thanks! I did not realize that this could be fixed with such a small change :-)

Changing triggerItem as you said might make sense, but I think it should be done in master only.

- Frank Reininghaus


On April 24, 2014, 7:50 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117755/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 7:50 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 311226
>     http://bugs.kde.org/show_bug.cgi?id=311226
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Mount partitions when you open them in a new tab.
> 
> Instead of just emitting the slotItemMiddleClicked signal in
> PlacesPanel::slotItemContextMenuRequested we now use triggerItem with
> Qt::MiddleButton, which does set up the storage first and emit
> the slotItemMiddleClicked signal afterwards.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placespanel.cpp d5308ea 
> 
> Diff: https://git.reviewboard.kde.org/r/117755/diff/
> 
> 
> Testing
> -------
> 
> Places panel -> Context menu -> Open partition in new tab works fine for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140426/d618480e/attachment.htm>