Review Request 117755: Mount partitions when you open them in a new tab.

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117755/#review56414
-----------------------------------------------------------



dolphin/src/panels/places/placespanel.cpp
<https://git.reviewboard.kde.org/r/117755/#comment39398>

    @Frank:
    I think we should create a new function and move most of the code from triggerItem to this new function. To decide which signal should be emitted we should add an enumeration (OpenInNewTab, OpenInCurrentView, ...).
    
    The diff will be much bigger but I think it will be easier to understand/read when we can use OpenInNewTab instead of MiddleButton ;)


- Emmanuel Pescosta


On April 24, 2014, 9:50 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117755/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 9:50 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 311226
>     http://bugs.kde.org/show_bug.cgi?id=311226
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Mount partitions when you open them in a new tab.
> 
> Instead of just emitting the slotItemMiddleClicked signal in
> PlacesPanel::slotItemContextMenuRequested we now use triggerItem with
> Qt::MiddleButton, which does set up the storage first and emit
> the slotItemMiddleClicked signal afterwards.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placespanel.cpp d5308ea 
> 
> Diff: https://git.reviewboard.kde.org/r/117755/diff/
> 
> 
> Testing
> -------
> 
> Places panel -> Context menu -> Open partition in new tab works fine for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140424/39cb28d1/attachment.htm>