Review Request 117395: Allow compiling dolphin with KF5

[Frank Reininghaus]

> On April 25, 2014, 2:19 p.m., Kai Uwe Broulik wrote:
> > Together with Review 117478 it works pretty well, however scrolling in the view is broken using a touchpad due to Qt 5.3's high-precision scrolling support.
> > 
> > Quoting from the release notes "Support for XInput2 smooth scrolling. The plugin now listens for XInput2 scrolling events which means it will respond to high resolution smooth scrolling events on devices where they are supported. Currently this is mainly touch pads."
> > 
> > The custom ItemView used by Dolphin doesn't handle this properly and will not scroll at all if you just scroll a little bit. Just something to keep in mind for later I guess.

Thanks for the info Kai!


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117395/#review56531
-----------------------------------------------------------


On April 10, 2014, 10:51 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117395/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 10:51 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Allow compiling Dolphin with KF5
> 
> This does not work properly yet, there are probably quite a few bad signal/
> slot connections due to KUrl -> QUrl. But at least dolphin starts without
> crashing.
> 
> Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5
> and I have no idea how it is supposed to be used.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d01c9b6 
>   dolphin/CMakeLists.txt 4b43d67 
>   dolphin/src/CMakeLists.txt 3f58479 
>   dolphin/src/dolphinapplication.cpp 8e83a85 
>   dolphin/src/dolphincontextmenu.cpp f295de7 
>   dolphin/src/dolphinmainwindow.cpp 8473014 
>   dolphin/src/dolphinpart.h 7146b46 
>   dolphin/src/dolphinpart.cpp 9081731 
>   dolphin/src/dolphinpart_ext.h c05962c 
>   dolphin/src/dolphinviewcontainer.h 31612f1 
>   dolphin/src/dolphinviewcontainer.cpp 768fd5e 
>   dolphin/src/kitemviews/kfileitemlistview.cpp fd01f2c 
>   dolphin/src/kitemviews/kfileitemmodel.cpp fd773e1 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 0865d40 
>   dolphin/src/kitemviews/kitemlistview.cpp 82f8a20 
>   dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 688ee9c 
>   dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h 1d56894 
>   dolphin/src/main.cpp a8e785a 
>   dolphin/src/panels/folders/treeviewcontextmenu.h 0b3fd79 
>   dolphin/src/panels/folders/treeviewcontextmenu.cpp fa8844d 
>   dolphin/src/panels/information/informationpanel.cpp eda74f3 
>   dolphin/src/panels/information/informationpanelcontent.cpp b2dd158 
>   dolphin/src/panels/information/phononwidget.cpp a36ada1 
>   dolphin/src/panels/places/placesitemeditdialog.cpp 08c910d 
>   dolphin/src/panels/places/placesitemmodel.cpp baa770d 
>   dolphin/src/panels/places/placespanel.cpp d5308ea 
>   dolphin/src/panels/terminal/terminalpanel.h 374476e 
>   dolphin/src/panels/terminal/terminalpanel.cpp bfd3002 
>   dolphin/src/search/dolphinsearchbox.cpp c178c43 
>   dolphin/src/search/filenamesearchprotocol.h 4a854d7 
>   dolphin/src/search/filenamesearchprotocol.cpp 4d6f59f 
>   dolphin/src/settings/dolphinsettingsdialog.cpp 609e2ab 
>   dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d 
>   dolphin/src/settings/general/configurepreviewplugindialog.cpp 3ca08df 
>   dolphin/src/settings/general/previewssettingspage.cpp 38b61b9 
>   dolphin/src/settings/kcm/kcmdolphingeneral.cpp 26cb580 
>   dolphin/src/settings/kcm/kcmdolphinnavigation.cpp 36345a5 
>   dolphin/src/settings/kcm/kcmdolphinservices.cpp 6d8c761 
>   dolphin/src/settings/kcm/kcmdolphinviewmodes.cpp a7a9db3 
>   dolphin/src/settings/serviceitemdelegate.h ea9681a 
>   dolphin/src/settings/serviceitemdelegate.cpp 7538e03 
>   dolphin/src/settings/services/servicessettingspage.cpp 48e816b 
>   dolphin/src/settings/viewmodes/viewsettingspage.cpp 4f8a3f0 
>   dolphin/src/settings/viewpropertiesdialog.cpp 574f8e1 
>   dolphin/src/views/dolphinitemlistview.cpp 4799d76 
>   dolphin/src/views/dolphinremoteencoding.cpp 04b350e 
>   dolphin/src/views/dolphinview.h 3731464 
>   dolphin/src/views/dolphinview.cpp 9f5f48a 
>   dolphin/src/views/dolphinviewactionhandler.cpp 48ec95c 
>   dolphin/src/views/renamedialog.cpp d8dbd77 
>   dolphin/src/views/tooltips/filemetadatatooltip.cpp b726996 
>   dolphin/src/views/tooltips/tooltipmanager.cpp bd69483 
>   dolphin/src/views/versioncontrol/updateitemstatesthread.cpp 6457f60 
>   dolphin/src/views/versioncontrol/versioncontrolobserver.h d12d2cf 
>   dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 36345d9 
>   dolphin/src/views/viewproperties.cpp d4ecfaf 
> 
> Diff: https://git.reviewboard.kde.org/r/117395/diff/
> 
> 
> Testing
> -------
> 
> Compiles, starts (but directory view is empty)
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140426/a29d4b0d/attachment.htm>