Review Request 117395: Allow compiling dolphin with KF5

Sat Apr 26 10:04:26 BST 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117395/#review56595
-----------------------------------------------------------

Thanks again for your KF5 porting efforts! Sorry for not having a closer look earlier. I had to make some small modifications to your patch:

1. Adjust changes in top-level CMakeLists.txt to some modifications that were pushed recently for the about kioslave.
2. Make tests build (they would still try to compile the a11y stuff, which you had disabled).
3. Prevent that dolphinsearchboxtest is built if HAVE_BALOO is not set. Strangely enough, building that test would fail for me even though kdesrc-build tells me that it has successfully built and installed Baloo. But I did not have a closer look - maybe it's easy to fix.

The updated diff is here, maybe you can update the request: http://paste.kde.org/ptstqrtia

I think the signal-slot change should be OK - I don't think that the behavior change will cause trouble (I'll also add a more detailed comment to that request, I just don't have much time right now), and I can confirm that it works nicely.

So the major remaining question is if Baloo should be re-enabled before the patch is pushed or not. I'm not sure how much work it will be (as I said above, the first contact of a unit test with Baloo on my system was unsuccessful), so it might be better to not delay your commit even further, push it in a few days if no issues are found, and work on Baloo support after that.

- Frank Reininghaus

On April 10, 2014, 10:51 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117395/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 10:51 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Allow compiling Dolphin with KF5
> 
> This does not work properly yet, there are probably quite a few bad signal/
> slot connections due to KUrl -> QUrl. But at least dolphin starts without
> crashing.
> 
> Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5
> and I have no idea how it is supposed to be used.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d01c9b6 
>   dolphin/CMakeLists.txt 4b43d67 
>   dolphin/src/CMakeLists.txt 3f58479 
>   dolphin/src/dolphinapplication.cpp 8e83a85 
>   dolphin/src/dolphincontextmenu.cpp f295de7 
>   dolphin/src/dolphinmainwindow.cpp 8473014 
>   dolphin/src/dolphinpart.h 7146b46 
>   dolphin/src/dolphinpart.cpp 9081731 
>   dolphin/src/dolphinpart_ext.h c05962c 
>   dolphin/src/dolphinviewcontainer.h 31612f1 
>   dolphin/src/dolphinviewcontainer.cpp 768fd5e 
>   dolphin/src/kitemviews/kfileitemlistview.cpp fd01f2c 
>   dolphin/src/kitemviews/kfileitemmodel.cpp fd773e1 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 0865d40 
>   dolphin/src/kitemviews/kitemlistview.cpp 82f8a20 
>   dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 688ee9c 
>   dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.h 1d56894 
>   dolphin/src/main.cpp a8e785a 
>   dolphin/src/panels/folders/treeviewcontextmenu.h 0b3fd79 
>   dolphin/src/panels/folders/treeviewcontextmenu.cpp fa8844d 
>   dolphin/src/panels/information/informationpanel.cpp eda74f3 
>   dolphin/src/panels/information/informationpanelcontent.cpp b2dd158 
>   dolphin/src/panels/information/phononwidget.cpp a36ada1 
>   dolphin/src/panels/places/placesitemeditdialog.cpp 08c910d 
>   dolphin/src/panels/places/placesitemmodel.cpp baa770d 
>   dolphin/src/panels/places/placespanel.cpp d5308ea 
>   dolphin/src/panels/terminal/terminalpanel.h 374476e 
>   dolphin/src/panels/terminal/terminalpanel.cpp bfd3002 
>   dolphin/src/search/dolphinsearchbox.cpp c178c43 
>   dolphin/src/search/filenamesearchprotocol.h 4a854d7 
>   dolphin/src/search/filenamesearchprotocol.cpp 4d6f59f 
>   dolphin/src/settings/dolphinsettingsdialog.cpp 609e2ab 
>   dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d 
>   dolphin/src/settings/general/configurepreviewplugindialog.cpp 3ca08df 
>   dolphin/src/settings/general/previewssettingspage.cpp 38b61b9 
>   dolphin/src/settings/kcm/kcmdolphingeneral.cpp 26cb580 
>   dolphin/src/settings/kcm/kcmdolphinnavigation.cpp 36345a5 
>   dolphin/src/settings/kcm/kcmdolphinservices.cpp 6d8c761 
>   dolphin/src/settings/kcm/kcmdolphinviewmodes.cpp a7a9db3 
>   dolphin/src/settings/serviceitemdelegate.h ea9681a 
>   dolphin/src/settings/serviceitemdelegate.cpp 7538e03 
>   dolphin/src/settings/services/servicessettingspage.cpp 48e816b 
>   dolphin/src/settings/viewmodes/viewsettingspage.cpp 4f8a3f0 
>   dolphin/src/settings/viewpropertiesdialog.cpp 574f8e1 
>   dolphin/src/views/dolphinitemlistview.cpp 4799d76 
>   dolphin/src/views/dolphinremoteencoding.cpp 04b350e 
>   dolphin/src/views/dolphinview.h 3731464 
>   dolphin/src/views/dolphinview.cpp 9f5f48a 
>   dolphin/src/views/dolphinviewactionhandler.cpp 48ec95c 
>   dolphin/src/views/renamedialog.cpp d8dbd77 
>   dolphin/src/views/tooltips/filemetadatatooltip.cpp b726996 
>   dolphin/src/views/tooltips/tooltipmanager.cpp bd69483 
>   dolphin/src/views/versioncontrol/updateitemstatesthread.cpp 6457f60 
>   dolphin/src/views/versioncontrol/versioncontrolobserver.h d12d2cf 
>   dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 36345d9 
>   dolphin/src/views/viewproperties.cpp d4ecfaf 
> 
> Diff: https://git.reviewboard.kde.org/r/117395/diff/
> 
> 
> Testing
> -------
> 
> Compiles, starts (but directory view is empty)
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140426/b638b752/attachment.htm>