Review Request 113191: Files passed as arguments: Ignore unsupported files and open archives as folders

[Erik Hahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113191/
-----------------------------------------------------------

(Updated Oct. 10, 2013, 2:53 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Made all the requested changes. Also I added a comment to the block I added that clarifies that, contrary what could be expected, "dirs" is the list that contains things that aren't folders.


Repository: kde-baseapps


Description
-------

With this patch, Dolphin ignores all files passed to it that it can't handle instead of opening them externally. I assume that it wasn't actually intended to be usable as a xdg-open replacement.

Also, archives are now opened inside Dolphin so it can be used as an archive manager at least for local files. If the user tries to open a remote archive Dolphin still opens it externally; I have observed that if it receives one as an argument, it will display a pseudo-folder that contains only said archive. So having it set as the archive handler is still broken, but in a less annoying way.


Diffs (updated)
-----

  dolphin/src/dolphinmainwindow.cpp 4128cdf 

Diff: http://git.reviewboard.kde.org/r/113191/diff/


Testing
-------


Thanks,

Erik Hahn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131010/bcc26c81/attachment.htm>