Review Request 113191: Files passed as arguments: Ignore unsupported files and open archives as folders

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113191/#review41509
-----------------------------------------------------------



dolphin/src/dolphinmainwindow.cpp
<http://git.reviewboard.kde.org/r/113191/#comment30334>

    Maybe "urlsToOpen" (or something similar) would make it slightly clearer what this list is about?
    
    At the moment, one really has to read all the code to see what the difference between "dirs" and "urls" is.



dolphin/src/dolphinmainwindow.cpp
<http://git.reviewboard.kde.org/r/113191/#comment30335>

    KUrl -> const KUrl&
    
    (Is slightly more efficient because it prevents that the URL is copied and the atomic reference count of its d-pointer has to be updated.)



dolphin/src/dolphinmainwindow.cpp
<http://git.reviewboard.kde.org/r/113191/#comment30336>

    const



dolphin/src/dolphinmainwindow.cpp
<http://git.reviewboard.kde.org/r/113191/#comment30337>

    const


Thanks for the patch! Version 2 looks good to me, I just added a few minor nitpicks inline.

- Frank Reininghaus


On Oct. 10, 2013, 12:49 p.m., Erik Hahn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113191/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2013, 12:49 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> With this patch, Dolphin ignores all files passed to it that it can't handle instead of opening them externally. I assume that it wasn't actually intended to be usable as a xdg-open replacement.
> 
> Also, archives are now opened inside Dolphin so it can be used as an archive manager at least for local files. If the user tries to open a remote archive Dolphin still opens it externally; I have observed that if it receives one as an argument, it will display a pseudo-folder that contains only said archive. So having it set as the archive handler is still broken, but in a less annoying way.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 4128cdf 
> 
> Diff: http://git.reviewboard.kde.org/r/113191/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erik Hahn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131010/c3de99ec/attachment.htm>