Review Request 110697: Dolphin Search: Do not use Nepomuk for hidden folders

[Vishesh Handa]

> On May 29, 2013, 2:41 p.m., Frank Reininghaus wrote:
> > Thanks for the patch, Vishesh!
> > 
> > Looks good, just some kdelibs coding style issues: don't put spaces inside (...), and always use {...} in if/else statements, even if there is only one line inside the block:
> > 
> > if (QFileInfo(dir.path()).isHidden()) {
> >     return true;
> > } else if (dir.cdUp()) {
> >     return isDirHidden(dir);
> > } else {
> >     return false;
> > }
> > 
> > Feel free to commit after changing the style. Thanks for your help.

Sorry about the coding style. I keep forgetting.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110697/#review33358
-----------------------------------------------------------


On May 28, 2013, 4:41 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110697/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 4:41 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
>     Nepomuk does not index hidden folders
> 
> 
> This addresses bug 318442.
>     http://bugs.kde.org/show_bug.cgi?id=318442
> 
> 
> Diffs
> -----
> 
>   dolphin/src/search/dolphinsearchinformation.cpp 31f6fcc 
> 
> Diff: http://git.reviewboard.kde.org/r/110697/diff/
> 
> 
> Testing
> -------
> 
> works!
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130529/4d10d25e/attachment.htm>