Review Request 110697: Dolphin Search: Do not use Nepomuk for hidden folders
Frank Reininghaus
frank78ac at googlemail.com
Wed May 29 15:41:49 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110697/#review33358
-----------------------------------------------------------
Thanks for the patch, Vishesh!
Looks good, just some kdelibs coding style issues: don't put spaces inside (...), and always use {...} in if/else statements, even if there is only one line inside the block:
if (QFileInfo(dir.path()).isHidden()) {
return true;
} else if (dir.cdUp()) {
return isDirHidden(dir);
} else {
return false;
}
Feel free to commit after changing the style. Thanks for your help.
- Frank Reininghaus
On May 28, 2013, 4:41 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110697/
> -----------------------------------------------------------
>
> (Updated May 28, 2013, 4:41 p.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> Nepomuk does not index hidden folders
>
>
> This addresses bug 318442.
> http://bugs.kde.org/show_bug.cgi?id=318442
>
>
> Diffs
> -----
>
> dolphin/src/search/dolphinsearchinformation.cpp 31f6fcc
>
> Diff: http://git.reviewboard.kde.org/r/110697/diff/
>
>
> Testing
> -------
>
> works!
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130529/ffe77d74/attachment.htm>
More information about the kfm-devel
mailing list