Review Request 110487: Bug 196035 - middle clicking on archive files in dolphin does not open them in a new tab

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110487/#review33287
-----------------------------------------------------------



dolphin/src/dolphincontextmenu.cpp
<http://git.reviewboard.kde.org/r/110487/#comment24627>

    I haven't tested it, but this looks to me like we never arrive here when the protocol is "search:". Have you tested this?
    



dolphin/src/dolphincontextmenu.cpp
<http://git.reviewboard.kde.org/r/110487/#comment24628>

    If my assumption above is correct, I would revert all changes above this 'else' and replace your 'else' by
    
    else if (!DolphinView::openItemAsFolderUrl(item).isEmpty())



dolphin/src/views/dolphinview.cpp
<http://git.reviewboard.kde.org/r/110487/#comment24629>

    I'm still not sure if this is the right place for the "browse through archives" settings check.
    
    IMHO, this setting refers to "browse through archives when clicking them, rather than opening Ark". When an archive is middle-clicked (or "Open in new Tab" is selected in the context menu), the user does obviously not want to open the archive in Ark. So I think that we should only check this setting in DolphinViewContainer::slotItemActivated(KFileItem)
    
    But maybe that's a matter of taste? Or is there a good reason why one should never open an archive as a folder if that setting is disabled (unless the user manually enters the URL of the archive in the location bar)? What do other people think about this?


- Frank Reininghaus


On May 28, 2013, 8:29 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110487/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 8:29 a.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> When 'browse through archives' is enabled, open archive files
> like folders on middle clicking, context menu -> new tab action
> and context menu -> new window action.
> 
> 
> This addresses bug 196035.
>     http://bugs.kde.org/show_bug.cgi?id=196035
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.cpp cddcc89 
>   dolphin/src/dolphinmainwindow.cpp 3b169a5 
>   dolphin/src/dolphinviewcontainer.cpp 44d4ee3 
>   dolphin/src/views/dolphinview.h e50dffc 
>   dolphin/src/views/dolphinview.cpp abf572f 
> 
> Diff: http://git.reviewboard.kde.org/r/110487/diff/
> 
> 
> Testing
> -------
> 
> Middle clicking or context menu -> new tab action opens the archive in a new tab, if 'browse through archives' is active.
> 
> Context menu -> new window action opens the archive in a new window, if 'browse through archives' is active.
> 
> Works for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130528/dfc5e8a0/attachment.htm>