Review Request 110487: Bug 196035 - middle clicking on archive files in dolphin does not open them in a new tab

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110487/
-----------------------------------------------------------

(Updated May 28, 2013, 8:29 a.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Replaced "bool DolphinView::itemCanBeOpenedAsFolder(const KFileItem& item, KUrl& url)" by "KUrl DolphinView::openItemAsFolderUrl(const KFileItem& item)", which returns an empty url if the item can't be opened as a folder but a valid and adjusted url if the item can be opened as a folder.

Also adjusted the code, so that multiple selected archives can be opened in multiple tabs (like open multiple folders in multiple tabs - commit 05d9210e)


Description
-------

When 'browse through archives' is enabled, open archive files
like folders on middle clicking, context menu -> new tab action
and context menu -> new window action.


This addresses bug 196035.
    http://bugs.kde.org/show_bug.cgi?id=196035


Diffs (updated)
-----

  dolphin/src/dolphincontextmenu.cpp cddcc89 
  dolphin/src/dolphinmainwindow.cpp 3b169a5 
  dolphin/src/dolphinviewcontainer.cpp 44d4ee3 
  dolphin/src/views/dolphinview.h e50dffc 
  dolphin/src/views/dolphinview.cpp abf572f 

Diff: http://git.reviewboard.kde.org/r/110487/diff/


Testing
-------

Middle clicking or context menu -> new tab action opens the archive in a new tab, if 'browse through archives' is active.

Context menu -> new window action opens the archive in a new window, if 'browse through archives' is active.

Works for me.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130528/d78d8e51/attachment.htm>