Review Request 110167: move focus to another view upon drop

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110167/#review33079
-----------------------------------------------------------

Ship it!


Just go ahead and push the commit to master then - if there is an issue with the approach that we haven't seen yet, we'll get feedback from beta testers.

Thanks for your work!

- Frank Reininghaus


On April 25, 2013, 1:43 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110167/
> -----------------------------------------------------------
> 
> (Updated April 25, 2013, 1:43 a.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Ok, here's my own solution with 312834, when drop the view, activate it.
> 
> Workflow:
> Open dolphin
> goto another folder
> split, open removable media or remote network place
> drag from origin view to splitted view
> close split
> 
> Now close split still code the "acitve" one, but since the active one is moved to the dragged one, close will not require user to change back to the old view.
> 
> 
> This addresses bug 312834.
>     http://bugs.kde.org/show_bug.cgi?id=312834
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp 502ffd4 
> 
> Diff: http://git.reviewboard.kde.org/r/110167/diff/
> 
> 
> Testing
> -------
> 
> Seems working.
> Test case:
> 1. drag from other application to inactive dolphin window, dolphin window didn't get focus
> 2. workflow in description.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130524/fb822597/attachment.htm>