Review Request 110167: move focus to another view upon drop

[Emmanuel Pescosta]

> On May 2, 2013, 1:53 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/views/dolphinview.cpp, line 1036
> > <http://git.reviewboard.kde.org/r/110167/diff/1/?file=140890#file140890line1036>
> >
> >     You only activate the DolphinView here, but the KUrlNavigator will stay inactive. This may trigger the "Q_ASSERT(m_view->isActive() == m_urlNavigator->isActive());" in DolphinViewContainer::isActive().
> >     
> >     Possible solutions:
> >     * Use DolphinViewContainer->setActive(bool) instead
> >     * Or connect the DolphinView::activated() signal with the DolphinViewContainer::activate() slot (Like the KUrlNavigator in DolphinViewContainer does) [I think this is the better solution]
> >     
> >

Ok this is not needed for the current Dolphin version, so your one-line patch is fine ;)

"Ship It" from my side!


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110167/#review31890
-----------------------------------------------------------


On April 25, 2013, 1:43 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110167/
> -----------------------------------------------------------
> 
> (Updated April 25, 2013, 1:43 a.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Ok, here's my own solution with 312834, when drop the view, activate it.
> 
> Workflow:
> Open dolphin
> goto another folder
> split, open removable media or remote network place
> drag from origin view to splitted view
> close split
> 
> Now close split still code the "acitve" one, but since the active one is moved to the dragged one, close will not require user to change back to the old view.
> 
> 
> This addresses bug 312834.
>     http://bugs.kde.org/show_bug.cgi?id=312834
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp 502ffd4 
> 
> Diff: http://git.reviewboard.kde.org/r/110167/diff/
> 
> 
> Testing
> -------
> 
> Seems working.
> Test case:
> 1. drag from other application to inactive dolphin window, dolphin window didn't get focus
> 2. workflow in description.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130502/e2eea235/attachment.htm>