Review Request 110505: set KItemListView m_styleOption.palette from scenes first view

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110505/
-----------------------------------------------------------

(Updated May 22, 2013, 9:46 p.m.)


Review request for Dolphin.


Changes
-------

"Proof" by setting inverted palettes on the dock or the view container (autofilling the background of the dock is required or you'll just get white-on-white with the patch - that's expected, though and would happen with "regular" widgets as well)

I didn't want to bring that up, but *every* graphicswidget keeps its own styleoption, with a (shallow) copy of the palette (and each needed to be updated)
Things would be more straightforward if the painting would just resolve the scene palette instead, but i wasn't sure whether there's perhaps a particular reason for copying the palette and other stuff around.

To keep the palette up-to-date filtering the graphicsview(s?) for PaletteChange events (and copying the widgets palette to the scene and eventually object styleoptions) is sufficient.

If you can explain or disregard the presence of the palette in the styleoption i can provide you second patch.


Description
-------

The palette is currently always constructed empty, thus defaults to the application general palette what fails if the view gets a different palette.
This is not "perfect" as it will not catch palette updates at runtime, but "works for me" (inverting docks at style polishment)

If QGraphicsWidget::palette() was used it would probably be possible to update the palette (via QGraphicsWidget::scene())


Diffs
-----

  dolphin/src/kitemviews/kitemlistview.h 6d609a9 
  dolphin/src/kitemviews/kitemlistview.cpp d009655 

Diff: http://git.reviewboard.kde.org/r/110505/diff/


Testing
-------

yes, getting readable text instead black-on-black


File Attachments (updated)
----------------

PoC
  http://git.reviewboard.kde.org/media/uploaded/files/2013/05/22/__proof.diff


Thanks,

Thomas Lübking

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130522/3241803d/attachment.htm>