Review Request 110505: set KItemListView m_styleOption.palette from scenes first view

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110505/#review32949
-----------------------------------------------------------


Thanks Thomas for the patch! I'm not really familiar with anything that is related to colors - any help in this area is greatly appreciated!

Could you describe briefly how the problem that you are fixing here can be reproduced? Thanks!

(Just for the record: there is a bug report about runtime color changes: https://bugs.kde.org/show_bug.cgi?id=315061).

- Frank Reininghaus


On May 18, 2013, 3 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110505/
> -----------------------------------------------------------
> 
> (Updated May 18, 2013, 3 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The palette is currently always constructed empty, thus defaults to the application general palette what fails if the view gets a different palette.
> This is not "perfect" as it will not catch palette updates at runtime, but "works for me" (inverting docks at style polishment)
> 
> If QGraphicsWidget::palette() was used it would probably be possible to update the palette (via QGraphicsWidget::scene())
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.h 6d609a9 
>   dolphin/src/kitemviews/kitemlistview.cpp d009655 
> 
> Diff: http://git.reviewboard.kde.org/r/110505/diff/
> 
> 
> Testing
> -------
> 
> yes, getting readable text instead black-on-black
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130522/b7c05cd7/attachment.htm>