Review Request 110371: Feature Request 312296 - open selected folders in new tabs

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110371/#review32948
-----------------------------------------------------------

Ship it!


Thanks for the new patch and sorry for the late response - I was away for a week, and I'm slowly catching up with all the unread mail in my inbox now.

Looks good, thanks for your work!

- Frank Reininghaus


On May 15, 2013, 8:03 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110371/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 8:03 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Make the item context menu entries: "Open in new Window", "Open in new Tab" and "Add to places" work for more than one selected folder.
> 
> Modified all involved functions to handle multiple selected items.
> 
> Check if the folders are already in the Places Model, before we add them to the Places Model in DolphinContextMenu::openItemContextMenu().
> 
> Also modified the KRun url from "dolphin %u" to "dolphin %U" -> All items are opened in the same new Dolphin Window.
> 
> 
> This addresses bug 312296.
>     http://bugs.kde.org/show_bug.cgi?id=312296
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.cpp af8b613 
>   dolphin/src/dolphinmainwindow.cpp 347489d 
> 
> Diff: http://git.reviewboard.kde.org/r/110371/diff/
> 
> 
> Testing
> -------
> 
> Works for me!
> 
> * Select multiple files and folder:
>   None of these three actions are visible.
> 
> * Select multiple files:
>   None of these three actions are visible.
> 
> * Select multiple folders (All folders are already in the Places Panel):
>   Only the actions "Open in new Window" and "Open in new Tab" are visible.
> 
> * Select multiple folders (Not all folders are in the Places Panel):
>   All three actions are visible.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130522/c8c21489/attachment.htm>