Review Request 110371: Feature Request 312296 - open selected folders in new tabs

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110371/
-----------------------------------------------------------

(Updated May 15, 2013, 8:03 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

* Removed the "Open In new Window" and "Add to places" action from DolphinContextMenu for multiple selected items
* Added the "Open In new Tabs" action


Description
-------

Make the item context menu entries: "Open in new Window", "Open in new Tab" and "Add to places" work for more than one selected folder.

Modified all involved functions to handle multiple selected items.

Check if the folders are already in the Places Model, before we add them to the Places Model in DolphinContextMenu::openItemContextMenu().

Also modified the KRun url from "dolphin %u" to "dolphin %U" -> All items are opened in the same new Dolphin Window.


This addresses bug 312296.
    http://bugs.kde.org/show_bug.cgi?id=312296


Diffs (updated)
-----

  dolphin/src/dolphincontextmenu.cpp af8b613 
  dolphin/src/dolphinmainwindow.cpp 347489d 

Diff: http://git.reviewboard.kde.org/r/110371/diff/


Testing
-------

Works for me!

* Select multiple files and folder:
  None of these three actions are visible.

* Select multiple files:
  None of these three actions are visible.

* Select multiple folders (All folders are already in the Places Panel):
  Only the actions "Open in new Window" and "Open in new Tab" are visible.

* Select multiple folders (Not all folders are in the Places Panel):
  All three actions are visible.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130515/da27376c/attachment.htm>