Review Request 109966: Don't try to change the icon of the "sort" action menu

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109966/#review32299
-----------------------------------------------------------


Thanks for the new patch! Looks reasonable, but I wonder why this could be an issue for the "view_mode" menu at all? The only situation in which this would become a problem is when there is a view mode without icon, right?

I'm OK with this being committed to KDE/4.10 (except for the "view_mode" changes, unless there is a very good reason to change it that I'm overlooking). If I shall do it for you, please let me know.

Well, there is actually a small problem left: Imagine you have set icons for the "Sort by" menu and for "Sort by Date", but not for "Sort by Name". When you switch to sorting by date, the menu's icon will be changed, but it does not change back when you switch to "Sort by Name". But I don't see a straightforward way to fix this right now, and I guess it's a rather unlikely corner case anyway.

- Frank Reininghaus


On May 8, 2013, 1:24 p.m., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109966/
> -----------------------------------------------------------
> 
> (Updated May 8, 2013, 1:24 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> When changing the sorting through the "sort" action menu, dolphin will try to change the icon.
> However this change fails and just removes the icon.
> 
> In my opinion there is no need at all to change the icon, it should always stay the same (it can be changed by the user with the kde tool bar editor btw.).
> 
> 
> This addresses bug 255819.
>     http://bugs.kde.org/show_bug.cgi?id=255819
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinviewactionhandler.cpp c7832d7 
> 
> Diff: http://git.reviewboard.kde.org/r/109966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130510/73a4a25d/attachment.htm>