Review Request 109966: Don't try to change the icon of the "sort" action menu

[Daniel Faust]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109966/
-----------------------------------------------------------

(Updated May 8, 2013, 3:24 p.m.)


Review request for Dolphin.


Changes
-------

- update icon only if it is not null
- do the same thing for the "view_mode" menu (the only similar case I have found)


Description
-------

When changing the sorting through the "sort" action menu, dolphin will try to change the icon.
However this change fails and just removes the icon.

In my opinion there is no need at all to change the icon, it should always stay the same (it can be changed by the user with the kde tool bar editor btw.).


This addresses bug 255819.
    http://bugs.kde.org/show_bug.cgi?id=255819


Diffs (updated)
-----

  dolphin/src/views/dolphinviewactionhandler.cpp c7832d7 

Diff: http://git.reviewboard.kde.org/r/109966/diff/


Testing
-------


Thanks,

Daniel Faust

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130508/3e849784/attachment.htm>