Review Request 110348: PlacesPanel: Do not allow drop events into timeline or search folder

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110348/#review32195
-----------------------------------------------------------


Hello Vishesh, 
thanks for helping us, to polish Dolphin for the KDE/4.11 release. :)

> Maybe we should show an error?
Error message really? I think a normal info message (yellow) would be enough.

There are some small UI problems in Dolphin with the KMessageWidget, because it moves the whole view down. (see comment from Thomas Lübking - https://git.reviewboard.kde.org/r/110327/).

I think we should move the KMessageWidget beneath the DolphinView and implement auto-disappearing for normal info messages. (Error messages should stay until the user closes it) - So the user is always informed why things (in this case dropping on timeline and search folders) doesn't work, but without annoying UI moves. ;)

@Frank: What do you think?


- Emmanuel Pescosta


On May 7, 2013, 10:50 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110348/
> -----------------------------------------------------------
> 
> (Updated May 7, 2013, 10:50 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
>     PlacesPanel: Do not allow drop events into timeline or search folder
>     
>     They are read only. You cannot modify them, so it makes no point showing
>     the "Move/Copy Into" context menu.
>     
>     Maybe we should show an error?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placespanel.cpp 0f5b83a 
> 
> Diff: http://git.reviewboard.kde.org/r/110348/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130507/65234f2c/attachment.htm>