Review Request 110348: PlacesPanel: Do not allow drop events into timeline or search folder

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110348/#review32193
-----------------------------------------------------------



dolphin/src/panels/places/placespanel.cpp
<http://git.reviewboard.kde.org/r/110348/#comment23967>

    Maybe const?



dolphin/src/panels/places/placespanel.cpp
<http://git.reviewboard.kde.org/r/110348/#comment23968>

    Maybe const?



dolphin/src/panels/places/placespanel.cpp
<http://git.reviewboard.kde.org/r/110348/#comment23969>

    Coding-Style: Please add {} brackets.
    
    Maybe move this check between "if (index < 0) { return; }" and "if (m_model->storageSetupNeeded(index)) { ..."?
    
    Just to make it more obvious which groups allow/don't allow dropping. What do you think?


- Emmanuel Pescosta


On May 7, 2013, 10:50 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110348/
> -----------------------------------------------------------
> 
> (Updated May 7, 2013, 10:50 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
>     PlacesPanel: Do not allow drop events into timeline or search folder
>     
>     They are read only. You cannot modify them, so it makes no point showing
>     the "Move/Copy Into" context menu.
>     
>     Maybe we should show an error?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placespanel.cpp 0f5b83a 
> 
> Diff: http://git.reviewboard.kde.org/r/110348/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130507/e59cf1d2/attachment.htm>