Review Request 110233: Fix problems with the synchronization between view URL and terminal panel directory when symbolic links are involved

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110233/
-----------------------------------------------------------

(Updated May 2, 2013, 5:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

Currently, when entering a folder which is a symbolic link, and the terminal panel is shown, the view URL is changed to the actual location of the folder after a moment.

I propose to fix this by comparing not only the URLs, but also verifying if the 'canonical path' returned by QDir for the current view URL is really different from the terminal's path before doing the change.


This addresses bug 302037.
    http://bugs.kde.org/show_bug.cgi?id=302037


Diffs
-----

  dolphin/src/panels/terminal/terminalpanel.cpp 28c6a93 

Diff: http://git.reviewboard.kde.org/r/110233/diff/


Testing
-------

Works for me, and the other aspects of the synchronization still work as well.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130502/71887a26/attachment.htm>