Review Request 110233: Fix problems with the synchronization between view URL and terminal panel directory when symbolic links are involved

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110233/#review31905
-----------------------------------------------------------


This review has been submitted with commit 2e123de94f6d654cbe37e4ac1841422632ca5451 by Frank Reininghaus to branch KDE/4.10.

- Commit Hook


On April 28, 2013, 9:04 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110233/
> -----------------------------------------------------------
> 
> (Updated April 28, 2013, 9:04 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Currently, when entering a folder which is a symbolic link, and the terminal panel is shown, the view URL is changed to the actual location of the folder after a moment.
> 
> I propose to fix this by comparing not only the URLs, but also verifying if the 'canonical path' returned by QDir for the current view URL is really different from the terminal's path before doing the change.
> 
> 
> This addresses bug 302037.
>     http://bugs.kde.org/show_bug.cgi?id=302037
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/terminal/terminalpanel.cpp 28c6a93 
> 
> Diff: http://git.reviewboard.kde.org/r/110233/diff/
> 
> 
> Testing
> -------
> 
> Works for me, and the other aspects of the synchronization still work as well.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130502/9d829d20/attachment.htm>