Review Request 111244: Fix Bug 320899 - blind spot in file managers between file name and file icon

Commit Hook null at kde.org
Wed Jun 26 21:10:22 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111244/
-----------------------------------------------------------

(Updated June 26, 2013, 8:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

Remove the space (1 pixel) between the file name and the file icon in Compact View and Details View mode.

Code changes for debugging the problem: Draw the text rectangle (blue) in debug mode.


This addresses bug 320899.
    http://bugs.kde.org/show_bug.cgi?id=320899


Diffs
-----

  dolphin/src/kitemviews/kstandarditemlistwidget.cpp 9a3f8f7 

Diff: http://git.reviewboard.kde.org/r/111244/diff/


Testing
-------

Works for me. See screenshots.


File Attachments
----------------

Compact View mode with gap
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/compact_view_with_gap.png
Compact View mode without gap (Patched)
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/compact_view_without_gap.png
Details View mode with gap
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/details_with_gap.png
Details View mode without gap (Patched)
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/details_without_gap.png


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130626/c31dc92d/attachment.htm>


More information about the kfm-devel mailing list