Review Request 111244: Fix Bug 320899 - blind spot in file managers between file name and file icon

[Emmanuel Pescosta]

> On June 25, 2013, 6:14 p.m., Frank Reininghaus wrote:
> > Thanks for the patch. To be honest, I can neither reproduce the bug, nor can I see any difference with and without the patch. But maybe I'm doing something wrong, I don't know. I don't really feel like spending much time on this issue (it has been reported by a person which turned out to be rather unpleasant in another bug report), but if you think it makes sense, feel free to push it. But I'd say that this should be master only, I'm not sure if the issue can really be considered a bug at all.
> > 
> > BTW, I appreciate that you look into all these little issues, and I know that I'm not really in a position to tell you what to do, but another issue that might be worth fixing is the "dropped files are not selected" regression that has recently been brought up and that might have been caused by a patch of yours.

> I can neither reproduce the bug
1. Enable "Show tooltips"
2. Go to compact/details view mode
3. Hover the file item name 
4. Move the mouse slowly to the file item icon

-> The tooltip gets closed and re-appears again (it flickers)

> I'm not sure if the issue can really be considered a bug at all.
Yes bug is the wrong word here, it's more a visual glitch and a small inconsistent behavior, 
because the icons view mode has no empty 1px gap between the file name and the file icon.

> but if you think it makes sense, feel free to push it
Yes it think it makes sense - pixel perfect Dolphin ;)

> should be master only
Ok.

> the "dropped files are not selected" regression
Yep I will definitely fix it!


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111244/#review35068
-----------------------------------------------------------


On June 25, 2013, 4:42 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111244/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 4:42 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Remove the space (1 pixel) between the file name and the file icon in Compact View and Details View mode.
> 
> Code changes for debugging the problem: Draw the text rectangle (blue) in debug mode.
> 
> 
> This addresses bug 320899.
>     http://bugs.kde.org/show_bug.cgi?id=320899
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 9a3f8f7 
> 
> Diff: http://git.reviewboard.kde.org/r/111244/diff/
> 
> 
> Testing
> -------
> 
> Works for me. See screenshots.
> 
> 
> File Attachments
> ----------------
> 
> Compact View mode with gap
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/compact_view_with_gap.png
> Compact View mode without gap (Patched)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/compact_view_without_gap.png
> Details View mode with gap
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/details_with_gap.png
> Details View mode without gap (Patched)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/25/details_without_gap.png
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130626/2d61d08d/attachment.htm>