Review Request 111111: Enable KIO error reporting also when renaming using the dialog
Commit Hook
null at kde.org
Sat Jun 22 08:22:41 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111111/#review34848
-----------------------------------------------------------
This review has been submitted with commit cafbdb59df98395ea56fe8c1e5da651d87036b5e by Frank Reininghaus to branch master.
- Commit Hook
On June 19, 2013, 7:02 a.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111111/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 7:02 a.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> This problem is that the RenameDialog passes itself to KonqOperations. However, when the error happens, the dialog does not exist any more. I think we can fix this by just passing the dialog's parent as the "widget" to KonqOperations.
>
>
> This addresses bug 299646.
> http://bugs.kde.org/show_bug.cgi?id=299646
>
>
> Diffs
> -----
>
> dolphin/src/views/renamedialog.cpp a16bb95
>
> Diff: http://git.reviewboard.kde.org/r/111111/diff/
>
>
> Testing
> -------
>
> Works for me.
>
>
> Thanks,
>
> Frank Reininghaus
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130622/621f950d/attachment.htm>
More information about the kfm-devel
mailing list