Review Request 111111: Enable KIO error reporting also when renaming using the dialog

[Frank Reininghaus]

> On June 21, 2013, 8:55 a.m., David Faure wrote:
> > Makes sense.

Thanks. BTW, I just noticed that I got a nice trophy for getting this particular review request number :-)


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111111/#review34810
-----------------------------------------------------------


On June 19, 2013, 7:02 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111111/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 7:02 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> This problem is that the RenameDialog passes itself to KonqOperations. However, when the error happens, the dialog does not exist any more. I think we can fix this by just passing the dialog's parent as the "widget" to KonqOperations.
> 
> 
> This addresses bug 299646.
>     http://bugs.kde.org/show_bug.cgi?id=299646
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/renamedialog.cpp a16bb95 
> 
> Diff: http://git.reviewboard.kde.org/r/111111/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130622/ea1a9f3a/attachment.htm>