Review Request 111630: Do not render icons on top of each other anymore

Commit Hook null at kde.org
Thu Jul 25 21:21:00 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111630/
-----------------------------------------------------------

(Updated July 25, 2013, 8:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

Do not render icons on top of each other anymore.

Set applyNewPos to false here is wrong in my mind, because the "if (applyNewPos) { widget->setPos(newPos); }" case will be never called, when items got removed and no move animation is running.


This addresses bug 302373.
    http://bugs.kde.org/show_bug.cgi?id=302373


Diffs
-----

  dolphin/src/kitemviews/kitemlistview.cpp d2b3fa1 

Diff: http://git.reviewboard.kde.org/r/111630/diff/


Testing
-------

Works for me.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130725/66649407/attachment.htm>


More information about the kfm-devel mailing list