Review Request 111630: Do not render icons on top of each other anymore

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111630/#review36506
-----------------------------------------------------------


This review has been submitted with commit 6e1a8774e9a3d99044fec4f5183b22baae5b1e63 by Frank Reininghaus to branch KDE/4.11.

- Commit Hook


On July 21, 2013, 2:28 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111630/
> -----------------------------------------------------------
> 
> (Updated July 21, 2013, 2:28 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Do not render icons on top of each other anymore.
> 
> Set applyNewPos to false here is wrong in my mind, because the "if (applyNewPos) { widget->setPos(newPos); }" case will be never called, when items got removed and no move animation is running.
> 
> 
> This addresses bug 302373.
>     http://bugs.kde.org/show_bug.cgi?id=302373
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.cpp d2b3fa1 
> 
> Diff: http://git.reviewboard.kde.org/r/111630/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130725/277cf0fb/attachment.htm>