Review Request 111505: Fix Bug 322348 - Removed labels still shows up in column view

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111505/#review36026
-----------------------------------------------------------

Ship it!


Thanks for the patch! Looks good from my point of view - very nice work! I think the branch should be "KDE/4.11" though.

- Frank Reininghaus


On July 14, 2013, 7:05 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111505/
> -----------------------------------------------------------
> 
> (Updated July 14, 2013, 7:05 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Overwrite the changed role value with an empty QVariant,
> because the nepomuk roles provider doesn't overwrite it when the property
> value list is empty.
> 
> 
> This addresses bug 322348.
>     http://bugs.kde.org/show_bug.cgi?id=322348
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h 20ce21c 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp eaaab6b 
>   dolphin/src/kitemviews/private/knepomukrolesprovider.h b8c7e51 
>   dolphin/src/kitemviews/private/knepomukrolesprovider.cpp 661670c 
> 
> Diff: http://git.reviewboard.kde.org/r/111505/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130716/f8ba9e88/attachment.htm>