Review Request 111505: Fix Bug 322348 - Removed labels still shows up in column view

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Sun Jul 14 20:05:18 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111505/
-----------------------------------------------------------

Review request for Dolphin.


Description
-------

Overwrite the changed role value with an empty QVariant,
because the nepomuk roles provider doesn't overwrite it when the property
value list is empty.


This addresses bug 322348.
    http://bugs.kde.org/show_bug.cgi?id=322348


Diffs
-----

  dolphin/src/kitemviews/kfileitemmodelrolesupdater.h 20ce21c 
  dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp eaaab6b 
  dolphin/src/kitemviews/private/knepomukrolesprovider.h b8c7e51 
  dolphin/src/kitemviews/private/knepomukrolesprovider.cpp 661670c 

Diff: http://git.reviewboard.kde.org/r/111505/diff/


Testing
-------

Works for me.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130714/01e4b73f/attachment.htm>


More information about the kfm-devel mailing list