Review Request: Wrong icons selected after pasting files and renaming them (because there exists items with it's names)

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107351/#review24546
-----------------------------------------------------------


First of all, happy new year and sorry for the late response, real life kept me quite busy around Christmas and New Year.

I'm fine with the Dolphin part of the change. About the issue concerning "Why have two methods instead of one?" raised by David: Sounds reasonable, one method is really sufficient, I think.

About the possible performance problem mentioned by David: I hadn't thought about that earlier. I will most likely not create a performance problem in Dolphin, given that the slot connected to urlPasted(KUrl) doesn't do anything expensive, but as soon as the signal is there, other apps might consider using it as well, and we don't know what they will do in slots connected to that signal. So it might indeed be worth looking into the possibility of emitting the signal for a bunch of URLs at once, if that is doable.

Thanks again for your awesome work. I know that may be a lot more work that one might have expected at first sight, but I'm sure that our users will greatly appreciate the result once it's finished.

- Frank Reininghaus


On Dec. 13, 2012, 11:42 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107351/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 11:42 p.m.)
> 
> 
> Review request for Dolphin, David Faure and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Bug 233335 - Wrong icons selected after pasting files and renaming them (because there exists items with it's names)
> 
> Dolphin 2.1 selects the existing items instead of the newly pasted + renamed items.
> 
> 
> This addresses bug 233335.
>     http://bugs.kde.org/show_bug.cgi?id=233335
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 11e03d0 
>   dolphin/src/dolphinviewcontainer.cpp c27550a 
>   dolphin/src/panels/folders/folderspanel.cpp 6e3a767 
>   dolphin/src/panels/places/placespanel.cpp 61c15a7 
>   dolphin/src/views/dolphinview.h a2fe9f6 
>   dolphin/src/views/dolphinview.cpp 941083f 
>   dolphin/src/views/draganddrophelper.h ac16f7c 
>   dolphin/src/views/draganddrophelper.cpp f81d4d0 
>   lib/konq/konq_operations.h b82feb4 
>   lib/konq/konq_operations.cpp e0f1ade 
> 
> Diff: http://git.reviewboard.kde.org/r/107351/diff/
> 
> 
> Testing
> -------
> 
> 1. Open a test folder with Dolphin.
> 2. Create the test files:
>     2.1. Open Dolphin’s terminal (F4).
>     2.2. Run “mkdir folder ; touch a b folder/b c d”.
>     2.3. Close Dolphin’s terminal (F4).
> 3. In the current folder, select the four empty files (a, b, c, d) and copy them (Ctrl+C).
> 4. Enter the “folder” folder.
> 5. Paste the files (Ctrl+V).
>     5.1. When asked for a new name for “b”, enter “b2” and hit Enter to continue.
> 
> Result:
> Items “a”, “b2”, “c”, “d” are selected
> 
> Btw. Thanks to Adrián Chaves Fernández for the easy way to test this bug ;)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130103/516a8172/attachment.htm>