Review Request 109020: Dolphin: return focus to file view when pressing "enter" in filter bar

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109020/#review27750
-----------------------------------------------------------


Thanks for the new patch! I took the liberty to make one little change (moved the connect statement to the DolphinViewContainer constructor to keep it consistent - all other connects from the filter bar are also done there) and pushed it to master.

- Frank Reininghaus


On Feb. 19, 2013, 6:35 p.m., Jens Rutschmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109020/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 6:35 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> This patch slightly changes the behavior of the dolphin filter bar to return back focus to the file/folder view when pressing "return" or "enter".
> 
> The patch is inspired by the comments of Frank Reininghaus here: https://bugs.kde.org/show_bug.cgi?id=297140#c6
> 
> 
> This addresses bug 297140.
>     http://bugs.kde.org/show_bug.cgi?id=297140
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.h bc58531 
>   dolphin/src/dolphinviewcontainer.cpp b2c8605 
>   dolphin/src/filterbar/filterbar.h 9546c63 
>   dolphin/src/filterbar/filterbar.cpp f3076f0 
> 
> Diff: http://git.reviewboard.kde.org/r/109020/diff/
> 
> 
> Testing
> -------
> 
> I tried it on top of 4.10 and it works :-)
> 
> 
> Thanks,
> 
> Jens Rutschmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130219/71a067a2/attachment.htm>