Review Request 109045: Big rewritte in KFileItemModel

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109045/
-----------------------------------------------------------

Review request for Dolphin and Frank Reininghaus.


Description
-------

Big rewritte in KFileItemModel: 
+ Get rid of the Url based item management 
+ Some performance improvements
+ Better handling of filtered items
+ Fix the treeview for timeline, trash, network-browser, ... (Different Url scheme)

Should fix bugs:
+ Bug 304565 - Network browser: details view breaks when expanding
+ Bug 312890 - Dolphin tries to render timeline:/ results as tree
+ Bug 311912 - After erasing a "filter", some thumbnails randomly disappear 


This addresses bugs 304565, 311912 and 312890.
    http://bugs.kde.org/show_bug.cgi?id=304565
    http://bugs.kde.org/show_bug.cgi?id=311912
    http://bugs.kde.org/show_bug.cgi?id=312890


Diffs
-----

  dolphin/src/kitemviews/kfileitemmodel.h a05d1f9 
  dolphin/src/kitemviews/kfileitemmodel.cpp 60fc275 
  dolphin/src/tests/kfileitemmodelbenchmark.cpp b1e777c 
  dolphin/src/tests/kfileitemmodeltest.cpp c9f8a34 

Diff: http://git.reviewboard.kde.org/r/109045/diff/


Testing
-------

+ Passes all tests
+ Renders timeline as a treeview without problems for files, timeline, trash (yes we can re-enable this), ...
+ Doesn't lose thumbnails anymore, when using the filterbar - Tested with 500 pictures (Also much faster response, esp. when you delete the filter string)

The bug 304565 needs some testing


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130219/f22ca45a/attachment.htm>