Review Request 109014: Don't show ellipsis on Rename action when inline renaming is enabled

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109014/#review27686
-----------------------------------------------------------


I don't think your patch goes in the spirit of the ellipsis rule.

The point of having an ellipsis is that you're not committing to the action by triggering it, that's why usually we say that if there's a dialog afterwards we want the ellipsis. In this case the ellipsis applies because by selecting rename we're not changing anything. It's when we press enter that we're committing to the rename action.

- Aleix Pol Gonzalez


On Feb. 18, 2013, 5:58 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109014/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 5:58 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> The ellipsis indicates to the user that when triggering the action a dialog that prompts further details (beyond a "are you sure?" confirmation) will appear. This is not the case when renaming inline.
> 
> Simple patch that uses a simple "Rename" in case inline renaming is enabled.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinviewactionhandler.cpp c7832d7 
> 
> Diff: http://git.reviewboard.kde.org/r/109014/diff/
> 
> 
> Testing
> -------
> 
> Works as expected. Action is not updated when inline renaming settings change. I doubt it is worth the effort to make it do that.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130218/44e27ee0/attachment.htm>