Review Request 109014: Don't show ellipsis on Rename action when inline renaming is enabled

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109014/#review27678
-----------------------------------------------------------


Thanks for the patch! This probably makes sense, but I have mixed feelings about a patch that removes a minor inconsistency and introduces a bug. I fully agree that it's not worth the effort to fix it (i.e., update the "..." if the "Rename Inline" setting has changed), but still, some people will notice it, and it might not be obvious that it depends on the state of that setting at startup. Therefore, I'd like to know if there is any evidence that this inconsistency is a problem for anyone? And if it is, we could just remove the "..." without any check at all. Inline renaming is the default after all (and I start thinking that we should probably not have added an option for it).

- Frank Reininghaus


On Feb. 18, 2013, 5:58 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109014/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 5:58 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> The ellipsis indicates to the user that when triggering the action a dialog that prompts further details (beyond a "are you sure?" confirmation) will appear. This is not the case when renaming inline.
> 
> Simple patch that uses a simple "Rename" in case inline renaming is enabled.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinviewactionhandler.cpp c7832d7 
> 
> Diff: http://git.reviewboard.kde.org/r/109014/diff/
> 
> 
> Testing
> -------
> 
> Works as expected. Action is not updated when inline renaming settings change. I doubt it is worth the effort to make it do that.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130218/4d1eeb83/attachment.htm>