Review Request 114228: Fix Bug 328262 - rename bug if you cancel when folder already exists

[Emmanuel Pescosta]

> On Dec. 2, 2013, 5:39 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! I haven't been able to test it yet, but have you verified that this does not bring https://bugs.kde.org/show_bug.cgi?id=319119 back? I can't see how both the current and the patched version of the code can have the same effect in the use case pointed out in that bug. Or, in other words: if the current code finds the file for which the renaming failed in the model with the URL 'newUrl' successfully in the use case of bug 319119, then how can it still work if we look for 'oldUrl'?

Good catch!

Thanks for the hint, this change does bring bug 319119 back :(

So we need some additional code to check, whether the renaming job was cancelled by the user or another problem happened while renaming.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114228/#review45000
-----------------------------------------------------------


On Nov. 30, 2013, 10:19 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114228/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2013, 10:19 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 328262
>     http://bugs.kde.org/show_bug.cgi?id=328262
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Use the old instead of the new item url to update the item text in the model.
> 
> Only the item text is temporarily renamed, the url is still the old one
> until the item was successfully renamed by KIO. So we must use the old url
> to access the right item.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp 20bc9f5 
> 
> Diff: http://git.reviewboard.kde.org/r/114228/diff/
> 
> 
> Testing
> -------
> 
> 1. Creat Folder 1 "Bar" 
> 2. Create Folder 2 "Foo" 
> 3. Rename Folder 2 into "Foo" and press Enter 
> 4. Cancel the question 
> 5. Folder 1 is still "Bar" and folder 2 is still "Foo"
> 
> Works for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131203/d3b82ca0/attachment.htm>