Review Request 114228: Fix Bug 328262 - rename bug if you cancel when folder already exists

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114228/#review45018
-----------------------------------------------------------

Ship it!


If you have tested that https://bugs.kde.org/show_bug.cgi?id=319119 is still fixed with this change, feel free to commit - your solution does look correct (and I don't have a good way to test it myself at the moment). I'm still a bit confused though why the existing code in that function is supposed to successfully fix bug 319119, and the patch doesn't change that. If you have some insights into this, please let us know :-)

- Frank Reininghaus


On Nov. 30, 2013, 9:19 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114228/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2013, 9:19 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 328262
>     http://bugs.kde.org/show_bug.cgi?id=328262
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Use the old instead of the new item url to update the item text in the model.
> 
> Only the item text is temporarily renamed, the url is still the old one
> until the item was successfully renamed by KIO. So we must use the old url
> to access the right item.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp 20bc9f5 
> 
> Diff: http://git.reviewboard.kde.org/r/114228/diff/
> 
> 
> Testing
> -------
> 
> 1. Creat Folder 1 "Bar" 
> 2. Create Folder 2 "Foo" 
> 3. Rename Folder 2 into "Foo" and press Enter 
> 4. Cancel the question 
> 5. Folder 1 is still "Bar" and folder 2 is still "Foo"
> 
> Works for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131202/0c3a0fb0/attachment.htm>