Review Request 109950: Scroll to newly pasted/dropped files.

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109950/#review30925
-----------------------------------------------------------


First of all, thanks for the patch!

Some remarks:

1. I have only noticed now that the slot "slotUrlPasted" does not exist at all. I must have missed this in your review request https://git.reviewboard.kde.org/r/107351/. This causes a runtime warning when pasting files -> probably the connection should be removed (in a separate commit), right?

2. I've noticed that we don't even select dropped files at the moment. I'm not entirely sure if this is intentional (maybe because the view where items are dropped is often the inactive one in a split view setup). I guess some research should be done before we change this.

3. When I first looked at the patch, I thought that it cannot work because markUrlAsCurrent(*it) is called in updateViewState *after* the current item is changed, and the new current item is scrolled to. But it does work sometimes (but not always), apparently because the function is called twice after pasting an item (possibly because the dir lister emits its completed() signal twice). Have you investigated this? I would prefer an approach that always works (and that would ideally not make updateViewState more complex than it is at the moment).

- Frank Reininghaus


On April 10, 2013, 6:38 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109950/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 6:38 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Scroll to newly pasted/dropped files.
> 
> If multiple files are pasted/dropped, then it scrolls
> to the first pasted/dropped file.
> 
> 
> This addresses bug 315722.
>     http://bugs.kde.org/show_bug.cgi?id=315722
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.h 13cc665 
>   dolphin/src/views/dolphinview.cpp d1e154f 
> 
> Diff: http://git.reviewboard.kde.org/r/109950/diff/
> 
> 
> Testing
> -------
> 
> Works. All test passed.
> 
> Paste one file -> Scrolls to this file
> Drop one file -> Scrolls to this file
> Paste multiple files -> Scrolls to the first inserted file
> Drop multiple files -> Scrolls to the first inserted file
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130411/0472a9a5/attachment.htm>