Review Request 109950: Scroll to newly pasted/dropped files.

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Wed Apr 10 19:43:51 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109950/#review30867
-----------------------------------------------------------



dolphin/src/views/dolphinview.cpp
<http://git.reviewboard.kde.org/r/109950/#comment22963>

    We use the aboutToCreate + slotAboutToCreate connection instead of the urlPasted + slotUrlPasted connection, because the slotAboutToCreate code can already select pasted files.
    
    So Dolphin handles dropped files in the same way as pasted files (Selection + mark as current)


- Emmanuel Pescosta


On April 10, 2013, 6:38 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109950/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 6:38 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Scroll to newly pasted/dropped files.
> 
> If multiple files are pasted/dropped, then it scrolls
> to the first pasted/dropped file.
> 
> 
> This addresses bug 315722.
>     http://bugs.kde.org/show_bug.cgi?id=315722
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.h 13cc665 
>   dolphin/src/views/dolphinview.cpp d1e154f 
> 
> Diff: http://git.reviewboard.kde.org/r/109950/diff/
> 
> 
> Testing
> -------
> 
> Works. All test passed.
> 
> Paste one file -> Scrolls to this file
> Drop one file -> Scrolls to this file
> Paste multiple files -> Scrolls to the first inserted file
> Drop multiple files -> Scrolls to the first inserted file
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130410/f34f0e4b/attachment.htm>


More information about the kfm-devel mailing list