hide/change the lineedit widget when renaming inline in Dolphin

[Daniel Kreuter]

On Thu, Sep 6, 2012 at 6:23 PM, Panos <panos.knvs at gmail.com> wrote:
> Hello,
>
> Sure, it's definitely trivial, and as I haven't seen any other complains about this it's probably a matter of personal taste. Answering Leo's question, both in OS X and in Windows inline renaming looks a little "simpler" with not many indications and frames. Of course that doesn't mean Dolphin's approach is worse :).
>
> So I'll look into moving the focus to the renamed item, taking into account your note about selecting multiple items.
>
> Thanks and regards,
>
> Panos
>
> On 6 Σεπ 2012, at 5:47 μ.μ., Frank Reininghaus wrote:
>
>> Hi,
>>
>> 2012/9/5 Panos:
>>> Hi Frank,
>>>
>>> Although I wasn't clear indeed, your answer was exactly what I wanted, so
>>> thanks :-). So it's a textedit and indeed I was referring to the frame of the
>>> textedit. I only added
>>>
>>> setFrameShape(QFrame::NoFrame);
>>
>> OK, thanks for the clarification!
>>
>>> in the KItemListRoleEditor's constructor and IMHO it looks a little better
>>> without the frame (and probably harmless so far :-)).
>>
>> I've tried it, and I'm inclined to think that it is slightly better
>> with the frame (for the reasons pointed out by Leo).
>>
>>> For
>>> example, selecting an item, moving the cursor over another item, and hitting
>>> F2, activates inline renaming for the selected item but the focus seems to
>>> remain on the item where the cursor was placed.
>>
>> Right, we could move the focus to the renamed item. But always keep in
>> mind that one can also rename multiple files simultaneously by
>> selecting them and then pressing F2 - this case should be tested as
>> well when you make any change.
>>
>> Best regards,
>> Frank
>

On windows 7 you get a frame around the item in windows explorer, so
removing it won't be so good I think. Like Leo just pointed out, the
user needs a visual reaction that he is now in editing mode.
The other point would be nice to be fixed.

So long

Daniel