Review Request: Fixes Bug 304878 - Dolphin shows "ghost" folders in places after autofs umount nfs shares

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106456/#review19094
-----------------------------------------------------------


Thanks for the quick update! This is good to go to the 4.9 branch (after fixing the two little issues below).


dolphin/src/panels/places/placesitemmodel.cpp
<http://git.reviewboard.kde.org/r/106456/#comment15180>

    Please add a 'const' here - we always do that for variables which don't change such that you can see at first sight that this is a constant.



dolphin/src/panels/places/placesitemmodel.cpp
<http://git.reviewboard.kde.org/r/106456/#comment15181>

    Looks good to me, but at the moment (i.e., in KDE 4.9.1), the item could be added with a non-empty text if the UDI is empty [see PlacesItem::setBookmark(const KBookmark& bookmark)].
    
    I'm not sure if this can actually happen, but I would prefer to not risk any regressions and add the item if the UDI is empty or if the non-empty UDI belongs to a valid device.
    
    -> if (udi.isEmpty() || !Solid::Device(udi).isValid())


- Frank Reininghaus


On Sept. 17, 2012, 4:44 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106456/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2012, 4:44 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fixes Bug 304878 - Dolphin shows "ghost" folders in places after autofs umount nfs shares 
> 
> Patch tested with a usb storage device, thanks to Weng Xuetian. His way to reproduce it:
> 1. open dolphin
> 2. plug a usb disk
> 3. mount a partition
> 4. unplug without unmount it.
> 5. ghost entry appears.
> 
> 
> This addresses bug 304878.
>     http://bugs.kde.org/show_bug.cgi?id=304878
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemmodel.cpp 5eb1c35 
> 
> Diff: http://git.reviewboard.kde.org/r/106456/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120918/5c2b5b5e/attachment.htm>