Review Request: Fixes Bug 304878 - Dolphin shows "ghost" folders in places after autofs umount nfs shares

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106456/
-----------------------------------------------------------

(Updated Sept. 17, 2012, 4:44 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Check if the bookmark has a valid UDI and if the device is valid device in PlacesItemModel::updateBookmarks()

Thanks to Frank for this great idea (much better approach) :)


Description
-------

Fixes Bug 304878 - Dolphin shows "ghost" folders in places after autofs umount nfs shares 

Patch tested with a usb storage device, thanks to Weng Xuetian. His way to reproduce it:
1. open dolphin
2. plug a usb disk
3. mount a partition
4. unplug without unmount it.
5. ghost entry appears.


This addresses bug 304878.
    http://bugs.kde.org/show_bug.cgi?id=304878


Diffs (updated)
-----

  dolphin/src/panels/places/placesitemmodel.cpp 5eb1c35 

Diff: http://git.reviewboard.kde.org/r/106456/diff/


Testing
-------


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20120917/205502df/attachment.htm>