Review Request: Fix Bug 240820 - [Usability Bug] Handling Bad Filenames, dolphin gives unclear error message

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107139/#review21171
-----------------------------------------------------------


In my opinion it should display the "'/' forbidden" error right above the input field. So not in a popup or a KMessageWidget bar. In the case of an inline rename i would say a KMessageWidget (error style) is the way to go.

This is just my opinion. Others might think differently. Just implement what you like most.

- Mark Gaiser


On Oct. 30, 2012, 8:10 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107139/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2012, 8:10 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix Bug 240820 - [Usability Bug] Handling Bad Filenames, dolphin gives unclear error message
> 
> Already done:
> * Rename inline: Filter slashes and show tooltip ("Slashes are not allowed in filenames")
> * Rename with Dialog: Filter slashes
> 
> Todo:
> * Rename with Dialog: Should give feedback to the user (tooltip or KMessageWidget?)
> * New File Dialog: Should filter slashes and should give feedback to the user (tooltip or KMessageWidget?) [KDELIBS]
> 
> 
> This addresses bugs 240820, 308597 and 309192.
>     http://bugs.kde.org/show_bug.cgi?id=240820
>     http://bugs.kde.org/show_bug.cgi?id=308597
>     http://bugs.kde.org/show_bug.cgi?id=309192
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kitemlistroleeditor.cpp 1e4b5fd 
>   dolphin/src/views/renamedialog.cpp a91f91b 
> 
> Diff: http://git.reviewboard.kde.org/r/107139/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121030/231ba2f3/attachment.htm>