Review Request: Fix Bug 240820 - [Usability Bug] Handling Bad Filenames, dolphin gives unclear error message

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107139/
-----------------------------------------------------------

(Updated Oct. 30, 2012, 8:10 p.m.)


Review request for Dolphin and Frank Reininghaus.


Description
-------

Fix Bug 240820 - [Usability Bug] Handling Bad Filenames, dolphin gives unclear error message

Already done:
* Rename inline: Filter slashes and show tooltip ("Slashes are not allowed in filenames")
* Rename with Dialog: Filter slashes

Todo:
* Rename with Dialog: Should give feedback to the user (tooltip or KMessageWidget?)
* New File Dialog: Should filter slashes and should give feedback to the user (tooltip or KMessageWidget?) [KDELIBS]


This addresses bugs 240820, 308597 and 309192.
    http://bugs.kde.org/show_bug.cgi?id=240820
    http://bugs.kde.org/show_bug.cgi?id=308597
    http://bugs.kde.org/show_bug.cgi?id=309192


Diffs
-----

  dolphin/src/kitemviews/private/kitemlistroleeditor.cpp 1e4b5fd 
  dolphin/src/views/renamedialog.cpp a91f91b 

Diff: http://git.reviewboard.kde.org/r/107139/diff/


Testing
-------


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121030/307de56d/attachment.htm>