Review Request: Port Dolphin from Nepomuk to Nepomuk2

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106825/#review20364
-----------------------------------------------------------


I guess my script isn't that great.

Once you have made the changes, please try doing a fresh build of Dolphin to see if everything is okay.


dolphin/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106825/#comment16106>

    NepomukCore_Found, not Nepomuk_FOUND



dolphin/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106825/#comment16107>

    Blank line. Please remove



dolphin/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106825/#comment16108>

    No longer required



dolphin/src/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106825/#comment16109>

    Ditto



dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp
<http://git.reviewboard.kde.org/r/106825/#comment16110>

    I don't think this file is required any more. The ResourceWatcher is now provided in NepomukCore. You guys don't need a copy of it.



dolphin/src/kitemviews/private/nepomuk/resourcewatcher.h
<http://git.reviewboard.kde.org/r/106825/#comment16111>

    Please get rid of this header and source file. NepomukCore now provides the resourcewatcher.


- Vishesh Handa


On Oct. 13, 2012, 2:16 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106825/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2012, 2:16 p.m.)
> 
> 
> Review request for Dolphin, Vishesh Handa and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Port Dolphin from Nepomuk to Nepomuk2 according to the Nepomuk2Port mini guide on techbase - http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 60d97d4 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h cabb003 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 5d6bdda 
>   dolphin/src/kitemviews/private/knepomukrolesprovider.h 1768356 
>   dolphin/src/kitemviews/private/knepomukrolesprovider.cpp b0e1798 
>   dolphin/src/kitemviews/private/nepomuk/resourcewatcher.h 96a75ef 
>   dolphin/src/kitemviews/private/nepomuk/resourcewatcher.cpp 2dcf567 
>   dolphin/src/panels/places/placesitemmodel.h 463e564 
>   dolphin/src/panels/places/placesitemmodel.cpp 4770c6b 
>   dolphin/src/search/dolphinfacetswidget.h 65734aa 
>   dolphin/src/search/dolphinfacetswidget.cpp 9306efd 
>   dolphin/src/search/dolphinsearchbox.cpp 6f1c736 
>   dolphin/src/search/dolphinsearchinformation.cpp 8af951a 
>   dolphin/src/settings/additionalinfodialog.cpp 3e23509 
>   dolphin/src/settings/viewpropertiesdialog.cpp 6c2b023 
>   dolphin/src/tests/CMakeLists.txt e1202ec 
>   dolphin/src/views/dolphinview.cpp def5740 
>   dolphin/src/views/dolphinviewactionhandler.cpp 0249964 
> 
> Diff: http://git.reviewboard.kde.org/r/106825/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121015/a971f256/attachment.htm>