Review Request: Port Dolphin from Nepomuk to Nepomuk2

[Frank Reininghaus]

> On Oct. 14, 2012, 5:12 p.m., Hrvoje Senjan wrote:
> > If you don't mind i would just say that i tested the patch, and with it the 'Additional information' within the view does not pickup the data from Nepomuk. Info panel's OK. Also, one is not able to enable the info with the patch. 
> > This is off course fixed with replacing all occurrences of NepomukFOUND with NepomukCore_FOUND in dolphin/src/CMakeLists.txt

I see, thanks for testing! I am away from my development machine for a couple of days and only checked that the changes match the instructions on techbase. Emmanuel, it would be great if you could update your patch according to the comments provided here when you find some time.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106825/#review20319
-----------------------------------------------------------


On Oct. 13, 2012, 2:16 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106825/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2012, 2:16 p.m.)
> 
> 
> Review request for Dolphin, Vishesh Handa and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Port Dolphin from Nepomuk to Nepomuk2 according to the Nepomuk2Port mini guide on techbase - http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 60d97d4 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h cabb003 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 5d6bdda 
>   dolphin/src/kitemviews/private/knepomukrolesprovider.h 1768356 
>   dolphin/src/kitemviews/private/knepomukrolesprovider.cpp b0e1798 
>   dolphin/src/kitemviews/private/nepomuk/resourcewatcher.h 96a75ef 
>   dolphin/src/kitemviews/private/nepomuk/resourcewatcher.cpp 2dcf567 
>   dolphin/src/panels/places/placesitemmodel.h 463e564 
>   dolphin/src/panels/places/placesitemmodel.cpp 4770c6b 
>   dolphin/src/search/dolphinfacetswidget.h 65734aa 
>   dolphin/src/search/dolphinfacetswidget.cpp 9306efd 
>   dolphin/src/search/dolphinsearchbox.cpp 6f1c736 
>   dolphin/src/search/dolphinsearchinformation.cpp 8af951a 
>   dolphin/src/settings/additionalinfodialog.cpp 3e23509 
>   dolphin/src/settings/viewpropertiesdialog.cpp 6c2b023 
>   dolphin/src/tests/CMakeLists.txt e1202ec 
>   dolphin/src/views/dolphinview.cpp def5740 
>   dolphin/src/views/dolphinviewactionhandler.cpp 0249964 
> 
> Diff: http://git.reviewboard.kde.org/r/106825/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20121015/9f230a56/attachment.htm>