Dolphin plugin for ownCloud

[Frank Reininghaus]

Hi Dominik,

2012/11/4 Dominik Schmidt:
>> You have the following in the constructor:
>>
>> m_owncloudSocket->connectToServer(m_socketPath);
>>
>> Isn't that a potentially expensive operation? I'm asking because that
>> code will be executed even if the user does not use ownCloud at all.
>
>
> At least it's async, so it doesn't make constructing the class slow. The
> connection is established in sendCommand() anyways, so I can probably just
> remove it in the ctor though.

Removing it from the constructor sounds like a good idea.

>>> Working on this I noticed the version control plugin is rather limited
>>> and
>>> not really suited for syncing plugins. Are there any other APIs that I
>>> could
>>> use?
>>
>>
>> I'm afraid that KVersionControlPlugin2 and
>> KAbstractFileItemActionPlugin are the only APIs that there are at the
>> moment.
>
>
> KAbstractFileItemActionPlugin looks good for adding a "sync this folder"
> menu. Do I need two separate plugins then? I'm sorry, I dont know the KDE
> plugin infrastructure too well :-)

I haven't worked on any plugins myself either yet, but I'm afraid that
two different plugins will be necessary indeed.

>>> 3.) Show custom icons. (?)
>>> I would like to add a custom overlay to icons with my own sync icons
>>> because
>>> the version control icons arent perfect fits for syncing and hard to
>>> understand by users.
>>
>>
>> Yes, it seems that this is not possible at the moment. I don't know
>> what the best approach to resolve this would be because I've never had
>> anything to do with the version control stuff, but maybe someone else
>> has an idea?
>
>
> Bummer once again. If I go for implementing it myself, would there be any
> interest to take it upstream? (good code assumed ofc) :)

I don't know if it's actually up to me to decide this because
KVersionControlPlugin2 isn't even part of Dolphin...

Do you mean that you would add a way to replace the currently used
icons for the different ItemVersions? Or rather add new ItemVersions?

Best regards,
Frank